Skip to content

[client-preset] Include undefined for inputMaybeValue explicitly #10393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

eddeee888
Copy link
Collaborator

Description

This PR includes undefined as part of inputMaybeValue so it would work nicely with tsconfig option exactOptionalPropertyTypes.

Without this explicit undefined, users with exactOptionalPropertyTypes enabled cannot set a value to undefined.

Related #10005

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit test

Copy link

changeset-bot bot commented Aug 6, 2025

🦋 Changeset detected

Latest commit: efb35af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/client-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 6, 2025

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-codegen/client-preset 4.8.4-alpha-20250806124710-efb35af844f5324e3d57c71e731b0b927866b260 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Aug 6, 2025

💻 Website Preview

The latest changes are available as preview in: https://pr-10393.graphql-code-generator.pages.dev

@eddeee888 eddeee888 requested a review from dotansimha August 12, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant